Generate unique labels for all form control inputs#3899
Merged
llastflowers merged 9 commits intomainfrom Feb 3, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 919c9a3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses an accessibility issue where form control inputs in preview files shared the same hardcoded ID ("bar"), causing screen readers to announce all labels simultaneously when focusing the first input. The fix generates unique IDs using SecureRandom.hex to ensure proper label-to-input association and correct screen reader announcements.
Changes:
- Generate unique field IDs dynamically using
SecureRandom.hex(6)for each form control preview instance - Update both the
label_argumentsand inputidto use the generated unique ID
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Clarified the description of label generation for form controls in previews.
…ement-fix' of github.com:primer/view_components into llastflowers/14752/formcontrol-preview-label-sr-announcement-fix
…-sr-announcement-fix
…ement-fix' of github.com:primer/view_components into llastflowers/14752/formcontrol-preview-label-sr-announcement-fix
…-sr-announcement-fix
…-sr-announcement-fix
liuliu-dev
approved these changes
Feb 2, 2026
llastflowers
deleted the
llastflowers/14752/formcontrol-preview-label-sr-announcement-fix
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Integration
N/A
List the issues that this change affects.
Addresses https://github.com/github/accessibility-audits/issues/14752
Risk Assessment
What approach did you choose and why?
The labels were all being announced at once when the first input was focused, because the inputs all had the same id which broke the label association. The other input labels were also not being announced. This updates the previews so that unique labels are generated for each input, addressing the SR announcement issues.
Anything you want to highlight for special attention from reviewers?
N/A
Accessibility
Fix for a11y audit remediation issue
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.